Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DML] Register DML operators for opset 19 #16939

Merged
merged 14 commits into from
Jan 22, 2024
Merged

[DML] Register DML operators for opset 19 #16939

merged 14 commits into from
Jan 22, 2024

Conversation

linnealovespie
Copy link
Contributor

Description

Register DML operators for opset 19.

  • Cast19
  • Castlike19
  • Constant19
  • Equal19
  • Identity19
  • QuantizeLinear19
  • DequantizeLinear19
  • Reshape19
  • Shape19
  • Size

Motivation and Context

@linnealovespie linnealovespie changed the title User/linneamay/dml 19 registration Register DML operators for opset 19 Jul 31, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2023
View reviewed changes
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_Constant = 19;
static const int sc_sinceVer_Equal = 19;
static const int sc_sinceVer_Identity = 19;
static const int sc_sinceVer_QuantizeLinear = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_QuantizeLinear' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_QuantizeLinear' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_Equal = 19;
static const int sc_sinceVer_Identity = 19;
static const int sc_sinceVer_QuantizeLinear = 19;
static const int sc_sinceVer_DequantizeLinear = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_DequantizeLinear' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_DequantizeLinear' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h Show resolved Hide resolved
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
namespace OnnxOperatorSet19
{
static const int sc_sinceVer_Cast = 19;
static const int sc_sinceVer_CastLike = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_CastLike' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_CastLike' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_Identity = 19;
static const int sc_sinceVer_QuantizeLinear = 19;
static const int sc_sinceVer_DequantizeLinear = 19;
static const int sc_sinceVer_Reshape = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Reshape' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Reshape' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
{
static const int sc_sinceVer_Cast = 19;
static const int sc_sinceVer_CastLike = 19;
static const int sc_sinceVer_Constant = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Constant' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Constant' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_Cast = 19;
static const int sc_sinceVer_CastLike = 19;
static const int sc_sinceVer_Constant = 19;
static const int sc_sinceVer_Equal = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Equal' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Equal' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_CastLike = 19;
static const int sc_sinceVer_Constant = 19;
static const int sc_sinceVer_Equal = 19;
static const int sc_sinceVer_Identity = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Identity' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Identity' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_QuantizeLinear = 19;
static const int sc_sinceVer_DequantizeLinear = 19;
static const int sc_sinceVer_Reshape = 19;
static const int sc_sinceVer_Shape = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Shape' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Shape' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
static const int sc_sinceVer_DequantizeLinear = 19;
static const int sc_sinceVer_Reshape = 19;
static const int sc_sinceVer_Shape = 19;
static const int sc_sinceVer_Size = 19;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Size' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'OperatorHelper::OnnxOperatorSet19::sc_sinceVer_Size' can be computed at compile-time. Consider using constexpr (con.5).
@linnealovespie linnealovespie changed the title Register DML operators for opset 19 [DML] Register DML operators for opset 19 Aug 2, 2023
@linnealovespie linnealovespie requested a review from fdwr August 3, 2023 18:20
@fdwr

This comment was marked as outdated.

Sign in to view
fdwr
fdwr reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments ⏳. Glad you figured it out, forming the graph and fill value constant 👍.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 11, 2023
View reviewed changes
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp Outdated
const DML_OPERATOR_DESC* opDescs[] = {&opDesc1, &opDesc2};
operatorGraphDesc.nodesAsOpDesc = std::data(opDescs);

const uint32_t fillValueNodeIndex = 0;

Check warning

Code scanning / PREfast

The const variable 'fillValueNodeIndex' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'fillValueNodeIndex' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp Outdated
operatorGraphDesc.nodesAsOpDesc = std::data(opDescs);

const uint32_t fillValueNodeIndex = 0;
const uint32_t dequantizeNodeIndex = 1;

Check warning

Code scanning / PREfast

The const variable 'dequantizeNodeIndex' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'dequantizeNodeIndex' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp Outdated
const DML_OPERATOR_DESC* opDescs[] = {&opDesc1, &opDesc2};
operatorGraphDesc.nodesAsOpDesc = std::data(opDescs);

const uint32_t fillValueNodeIndex = 0;

Check warning

Code scanning / PREfast

The const variable 'fillValueNodeIndex' can be computed at compile-time. Consider using constexpr (con.5).

The const variable 'fillValueNodeIndex' can be computed at compile-time. Consider using constexpr (con.5).
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp Outdated Show resolved Hide resolved
fdwr
fdwr reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Next round should be good.

@linnealovespie linnealovespie reopened this Jan 5, 2024
@linnealovespie linnealovespie marked this pull request as draft January 5, 2024 21:31
@linnealovespie linnealovespie marked this pull request as ready for review January 8, 2024 22:32
@linnealovespie linnealovespie requested a review from smk2007 January 8, 2024 23:06
fdwr
fdwr previously approved these changes Jan 18, 2024
View reviewed changes
fdwr
fdwr previously approved these changes Jan 19, 2024
View reviewed changes
smk2007
smk2007 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@smk2007 smk2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@linnealovespie linnealovespie merged commit 24b74ae into main Jan 22, 2024
91 of 94 checks passed
@linnealovespie linnealovespie deleted the user/linneamay/dml-19-registration branch January 22, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk2007 smk2007 smk2007 approved these changes

@fdwr fdwr fdwr left review comments

@PatriceVignola PatriceVignola Awaiting requested review from PatriceVignola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linnealovespie @fdwr @PatriceVignola @smk2007